Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@7 PS5, Line 7: mb/google/volteer/variants/volteer : Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@8 PS5, Line 8: This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency Please add a blank line above to separate the commit message summary from the body.
https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@8 PS5, Line 8: scl_lcnt,scl_hcnt,scl_hcnt Please add a space after each ,.
https://review.coreboot.org/c/coreboot/+/42678/5//COMMIT_MSG@9 PS5, Line 9: closer to 400kHz. What is the current frequency (before the patch)?