Attention is currently required from: Arthur Heymans, Fred Reitberger, Martin Roth, Zheng Bao.
Hello Arthur Heymans, Fred Reitberger, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72959?usp=email
to look at the new patch set (#14).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Support firmware offsets of larger than 16MiB ......................................................................
amdfwtool: Support firmware offsets of larger than 16MiB
The mapped windows is up to 16M. Even if the flash size is 32MB, it is not mapped at 0xFE000000.
So using "0xFFFFFFFF - rom_size + 1" to get the "rom_base_address" can only explain well when rom_size is less or equal to 16MB. For larger size, it is not physically correct (Even though it can get expected result).
If the flash size is larger than 16M, we assume the given addresses are already relative ones. So we don't need the physical base address any more.
This commit is part of a series of patches to support 32/64M flash. BUG=b:255374782
Change-Id: I9eea45f0be45a959c4150030e7e213923510ad68 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/72959/14