Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42365 )
Change subject: common/Makefile.inc: Factor out generation TLAs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/42365/1/common/Makefile.inc
File common/Makefile.inc:
https://review.coreboot.org/c/libgfxinit/+/42365/1/common/Makefile.inc@91
PS1, Line 91: -e's/<($(_GEN_TLA_SUBSTITUTIONS)(...)?)bool>/<\1var> Boolean/' \
The additional backslashes are only needed because you exit the quotation […]
Done
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/42365
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I63cb24d7334359d39aca4682632c3b9b6b698d43
Gerrit-Change-Number: 42365
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 22 Jun 2020 22:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment