Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35481 )
Change subject: soc/mediatek/mt8183: Clean cached calibration results if mem test fails ......................................................................
Patch Set 47:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35481/45/src/soc/mediatek/mt8183/me... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/35481/45/src/soc/mediatek/mt8183/me... PS45, Line 160: 0
use 0xff, which is the native uninitialized data on SPI flash. […]
1. If 'dparam' is not cleared now, is there a way to clear the flash? We're using 'fmap_overwrite_area()' now and I didn't find an API to directly clear fmap. I thought this memset was only for clearing the flash.
2. If we use a special STATUS to prevent running full-k if it failed previously, those failed devices would always run partial-k (until next version). If the mem test somehow passed, it would be even harder for us to know that full-k failed on those devices, right?