Attention is currently required from: Paul Menzel, Ren Kuo, Rob Barnes, Karthik Ramasubramanian, Karthikeyan Ramasubramanian.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59975 )
Change subject: mb/google/guybrush/var/dewatt: Add Elan touchscreen
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59975/comment/d2f0fc4a_1a94c5b2
PS6, Line 9: Add Elan 6918 touchscreen for dewatt.
Please mention the datasheet name and revision, you got the values from.
Done
https://review.coreboot.org/c/coreboot/+/59975/comment/8bd711a3_390acb81
PS6, Line 12: touchscree
touchscreen
Done
File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59975/comment/9a9104ce_cdfb5156
PS2, Line 67: register "generic.stop_delay_ms" = "280"
Long resume time is not OK. Please measure resume time impact of this touchscreen. […]
After discussing to betty.tsai@emc.com.tw , removed stop_delay_ms and tested with elan 6918.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59975
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a7f5891e09ffa393c93881be68641d955efdf8
Gerrit-Change-Number: 59975
Gerrit-PatchSet: 8
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Mon, 13 Dec 2021 11:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment