Attention is currently required from: Nico Huber, Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83556?usp=email )
Change subject: soc/intel/cnvi: Add CNVW OpRegion
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cnvi/cnvi.c:
https://review.coreboot.org/c/coreboot/+/83556/comment/93cd804c_47f03c8a?usp... :
PS6, Line 40: dev->path.pnp.port, 2
Oh, this is PCI config space? that's confusing, there should be an ACPI […]
`GPCB() + <offset>` is used in coreboot's tcss.asl for TGL/ADL/MTL, though it would be nice to know where this offset is coming from
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83556?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd2ff93fb65c40f656804d96966e1881202ccb56
Gerrit-Change-Number: 83556
Gerrit-PatchSet: 11
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 02 Aug 2024 13:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de