Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36845 )
Change subject: security/vboot: Remove selected_region from struct vboot_working_data
......................................................................
Patch Set 4:
(1 comment)
Patch Set 2:
(3 comments)
I agree with Aaron's points, I think it would be cleaner to just remove the selected_region field and everything related to it right away, rather than leaving things in this half-state where some code still looks at that and some doesn't anymore.
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/vboot_lo...
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/vboot_lo...
PS1, Line 453: vboot_set_selected_region(region_device_region(&fw_main));
Merged with CB:36847.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27cb1a2175beb189053fc3e44b17b60aba474bb0
Gerrit-Change-Number: 36845
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 Nov 2019 03:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment