Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19684 )
Change subject: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19684/1/src/soc/intel/common/block/pcr/pcr.c
File src/soc/intel/common/block/pcr/pcr.c:
PS1, Line 27: #if(CONFIG_PCR_BASE_ADDRESS ==0)
: #error "PCR_BASE_ADDRESS need to be non-zero!"
: #endif
This does not need to be in a function. Move it above all of this. Also, fi
Done
--
To view, visit
https://review.coreboot.org/19684
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I396aa1a3e89507c90e17229a986de5d2c0887c9c
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes