Attention is currently required from: Martin Roth, Chris Wang, chris wang.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52709 )
Change subject: mb/google/mancomb: Add STAPM values to overridetree
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52709/comment/be728017_e6b85902
PS2, Line 9: .
Remove period, also can flow some of the text on the next line up to here.
https://review.coreboot.org/c/coreboot/+/52709/comment/10ed76ad_215fe263
PS2, Line 9: f
Cap F
File src/mainboard/google/mancomb/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52709/comment/e408095d_13b66ae0
PS2, Line 4:
Nit, remove extra whitespace. I don't see this aligning vertically with anything. I suspect the line was copy/pasted from the other file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3ed76e5212a5a8b5fb4fcc3d6884ceff82377b7
Gerrit-Change-Number: 52709
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Thu, 29 Apr 2021 00:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment