Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85360?usp=email )
Change subject: mb/google/rauru: Add 2nd source tas2563 amps to support beep ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85360/comment/0b46fa71_2602723c?usp... : PS3, Line 12: 357969183 b:357969183
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85360/comment/327649da_cb2fd6f4?usp... : PS3, Line 31: printk(BIOS_INFO, "Audio configure.\n"); Move to the end of the function. and print ``` printk(BIOS_INFO, "%s: done\n", __func__); ```
https://review.coreboot.org/c/coreboot/+/85360/comment/a55f1cc2_ba5afb21?usp... : PS3, Line 33: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_NAU8318))) { : return; : } else Just remove.