[coreboot-gerrit] [L] Change in coreboot[main]: soc/intel/common/block/imc: Add Integrated Memory Controller driver

[Shuo Liu (Code Review)]

Attention is currently required from: Felix Singer, Jérémy Compostella, [e-mail].

Shuo Liu has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )

Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver
......................................................................

Patch Set 15:

(4 comments)

File src/soc/intel/common/block/imc/Kconfig:

https://review.coreboot.org/c/coreboot/+/83320/comment/1fc0e855_22d4709f?usp... :
PS3, Line 4: 	bool
> IMC is originally added by commit f377fafd941a44252c4c7527ba08f798d222e7ff to support Intel Xeon Pro […]

IMO this is the 1st active IMC implementation, we can postpone the consideration of being reused by others now.

File src/soc/intel/common/block/include/intelblocks/imc.h:

https://review.coreboot.org/c/coreboot/+/83320/comment/cae172f7_700e4b14?usp... :
PS15, Line 10: 
can these be static? or to static what ever could be?

File src/soc/intel/common/block/smbus/smbuslib.c:

https://review.coreboot.org/c/coreboot/+/83320/comment/530d04a0_6974586e?usp... :
PS3, Line 10: {
> Sorry for the typo, I mean in `coreboot/src/soc/intel/common/block/smbus/Makefile. […]

sure, let us remove the weak here

https://review.coreboot.org/c/coreboot/+/83320/comment/2752a7a4_d5cb61dc?usp... :
PS3, Line 96: 		if (!CONFIG(SOC_INTEL_COMMON_BLOCK_IMC) && blk->addr_map[i] == 0) {
> The addr_map[i] is finally used as the address of the slave. […]

add a common block here might be helpful