Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34587 )
Change subject: soc/*/mp_init: Increase timeout to 1 s
......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@9
PS3, Line 9: s
usually
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@10
PS3, Line 10: it's
its
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/apollolake/cp...
File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/apollolake/cp...
PS3, Line 259: 100
100 or 1000?
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/skylake/cpu.c
File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/skylake/cpu.c...
PS3, Line 494: 100
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I456be647b159f7a2ea7d94986a24424e56dcc8c4
Gerrit-Change-Number: 34587
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 28 Jul 2019 00:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment