Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46886 )
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
soc/intel/broadwell: Use `mp_cpu_bus_init`
Change-Id: Ic642f32f9c4a269a66ac470b7a7217f20ff8bfba Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/cpu/cpu.c M src/soc/intel/broadwell/cpu/haswell.h M src/soc/intel/broadwell/northbridge.c 3 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46886/1
diff --git a/src/soc/intel/broadwell/cpu/cpu.c b/src/soc/intel/broadwell/cpu/cpu.c index 9348439..10db364 100644 --- a/src/soc/intel/broadwell/cpu/cpu.c +++ b/src/soc/intel/broadwell/cpu/cpu.c @@ -614,10 +614,8 @@ .post_mp_init = post_mp_init, };
-void broadwell_init_cpus(struct device *dev) +void mp_init_cpus(struct bus *cpu_bus) { - struct bus *cpu_bus = dev->link_list; - if (mp_init_with_smm(cpu_bus, &mp_ops)) printk(BIOS_ERR, "MP initialization failure.\n"); } diff --git a/src/soc/intel/broadwell/cpu/haswell.h b/src/soc/intel/broadwell/cpu/haswell.h index 399fc23..26077a7 100644 --- a/src/soc/intel/broadwell/cpu/haswell.h +++ b/src/soc/intel/broadwell/cpu/haswell.h @@ -120,8 +120,6 @@ void set_power_limits(u8 power_limit_1_time); int cpu_config_tdp_levels(void);
-void broadwell_init_cpus(struct device *dev); - void set_max_freq(void);
/* CPU identification */ diff --git a/src/soc/intel/broadwell/northbridge.c b/src/soc/intel/broadwell/northbridge.c index 980be4d..73c6e83 100644 --- a/src/soc/intel/broadwell/northbridge.c +++ b/src/soc/intel/broadwell/northbridge.c @@ -461,7 +461,7 @@ static struct device_operations cpu_bus_ops = { .read_resources = noop_read_resources, .set_resources = noop_set_resources, - .init = &broadwell_init_cpus, + .init = &mp_cpu_bus_init, };
static void broadwell_enable(struct device *dev)