Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42706 )
Change subject: mb/amd/mandolin: maximize CBFS size ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42706/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42706/1//COMMIT_MSG@7 PS1, Line 7: mb/amd/mandolin: maximize CBFS size
don't think that it matters much how much the cbfs grew. […]
How should reviewers verify, that your changed values are correct?
https://review.coreboot.org/c/coreboot/+/42706/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/42706/1/src/mainboard/amd/mandolin/... PS1, Line 32: Mandolin
This maximum cbfs size is very specific to the mandolin fmap, so I don't see much reason to remove m […]
It’s `src/mainboard/amd/madolin/Kconfig`, so it’s clear it’s for Mandolin?
Anyway, the other boards do not seem to have a description at all, so I’d remove it.