Mary Ruthven has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44646 )
Change subject: vendorcode/google/chromeos: Introduce helper for CSE board reset
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44646/6/src/vendorcode/google/chrom...
File src/vendorcode/google/chromeos/cse_board_reset.c:
https://review.coreboot.org/c/coreboot/+/44646/6/src/vendorcode/google/chrom...
PS6, Line 25: if (version.epoch != 0 || version.major != 0 || version.minor > 22)
: return;
:
From the release notes, it's 0.{3,4}.25 or later.
We modified the defaults in 0.{3,4}.20, so straps with a PU on DIOA1 would default to PLT_RST even if they aren't in the cr50 strap table.
so 3/4.20 are the first images the strap support.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44646
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8078e2436d1d58a650bf7b0cf38b5bb89a474187
Gerrit-Change-Number: 44646
Gerrit-PatchSet: 7
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mary Ruthven
mruthven@chromium.org
Gerrit-Comment-Date: Fri, 21 Aug 2020 16:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment