Attention is currently required from: Arthur Heymans, Fred Reitberger, Jason Glenesk.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80407?usp=email )
Change subject: soc/amd/common/data_fabric/domain: don't report DRAM as MMIO producer
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/data_fabric/domain.c:
https://review.coreboot.org/c/coreboot/+/80407/comment/cbf7945b_f153a1a9 :
PS1, Line 285: IORESOURCE_CACHEABLE
would IORESOURCE_STORED be more appropriate?
that should cover both IORESOURCE_RESERVE and IORESOURCE_CACHEABLE cases, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80407?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7b6d3fd8c7f89aa4364de7963d745aef8d6b6f42
Gerrit-Change-Number: 80407
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 20:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment