Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31445 )
Change subject: soc/intel/cannonlake: Add a power control workaround for SD controller
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/31445/8/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31445/8/src/soc/intel/cannonlake/Kconfig@238
PS8, Line 238: config MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
This adds a redundant setting. If I'm not complete confused,
we have that information already somewhere in the mainboard
code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31445
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee262d7ecdf8c31362aec3d95dd9b3e8359e0c25
Gerrit-Change-Number: 31445
Gerrit-PatchSet: 8
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Feb 2019 09:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment