Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34287 )
Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: -Code-Review
(1 comment)
I've just boot-tested all affected boards (empty set, assuming abuilds
configurations). So I don't think we should put more effort into this.
However, on the FSP-T integration side, I've learned by now that my
initial hunch why my board isn't booting must have been wrong: I thought
it was because I left CPU_MICROCODE_CBFS_LEN/_LOC at 0. But the FSP
integration guide for CFL (what I tested) says this would be ok.
So it would be really nice if somebody could confirm if the FSP-T
integration works/ever worked upstream.
HI Maurice/BT/KW/Lean Sheng, can you please share your opinion on FSP-T integration work in upstream ?
i remember to implement chrome-coreboot was using FSP_T till SKL platform and i have validated that flow. so code should be in upsteam for sure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30b1808f91701c07dce6f1de08c213150e8a675a
Gerrit-Change-Number: 34287
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Kin Wai Ng
kin.wai.ng@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sat, 13 Jul 2019 14:33:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment