Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31894 )
Change subject: soc/intel/cannonlake: Enable power button smi in pre-OS ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31894/2/src/soc/intel/cannonlake/pmc.c File src/soc/intel/cannonlake/pmc.c:
https://review.coreboot.org/#/c/31894/2/src/soc/intel/cannonlake/pmc.c@68 PS2, Line 68: only before jumping to payload Wouldn't you need to remove enabling of power button smi from here: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/cannonlake/...