Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31683 )
Change subject: mb/google/sarien: add ish firmware_variant field to _DSD ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/#/c/31683/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31683/4//COMMIT_MSG@13 PS4, Line 13: BRANCH=none
BRANCH is not needed here
Done
https://review.coreboot.org/#/c/31683/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31683/5//COMMIT_MSG@9 PS5, Line 9: ISH
Could be spelled out in the commit message.
Done
https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... PS4, Line 200: arcada_ish
The _DSD() should return full filename. […]
Done
https://review.coreboot.org/#/c/31683/4/src/mainboard/google/sarien/variants... PS4, Line 200: firmware_variant
"firmware-name"?
Done