Attention is currently required from: Hung-Te Lin, Kiwi Liu, Mengqi Zhang, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Kiwi Liu. ( https://review.coreboot.org/c/coreboot/+/84298?usp=email )
Change subject: soc/mediatek/common: Correct eMMC src clk frequency to 400 MHz
......................................................................
Patch Set 16: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84298/comment/2112a717_31d6b8e4?usp... :
PS12, Line 14: measure eMMC clock ok
https://partnerissuetracker.corp.google.com/issues/356578805#comment44 […]
Please mention the boot time impact (or no impact) in the commit message.
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/84298/comment/dff9d473_baf66172?usp... :
PS15, Line 432: 400 * 1000 * 1000
In the eMMC coreboot driver, because it involves some MHz and KHz calculation, in order to make the […]
Fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c8836b23fb21e9b0bdc80fbe85142ea0fa5e381
Gerrit-Change-Number: 84298
Gerrit-PatchSet: 16
Gerrit-Owner: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 06:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com