Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34587 )
Change subject: soc/*/mp_init: Increase timeout to 1 s ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@12 PS3, Line 12: most mp_run_on_all_cpus calls
How did you decide which calls to increase the timeout for? Would it be better to add a function mp_ […]
The first call in post_mp_init should never fail as all APs are idle, due to previous synchronisation in mp init.
Sounds good, but how to know if the caller doesn't care about a special timeout? Do we need a special (non default) timeout?
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/apollolake/cp... File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/apollolake/cp... PS3, Line 259: 100
100 or 1000?
was chosen as APs are idle at start of post_mp_init. That cannot be said for sure after post_mp_init.