17 Oct
2019
17 Oct
'19
3:55 a.m.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36086 )
Change subject: mb/google/hatch/akemi: disable unused devices for Akemi ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36086/2/src/mainboard/google/hatch/... PS2, Line 6: [PchSerialIoIndexI2C2] = PchSerialIoPci, : [PchSerialIoIndexI2C3] = PchSerialIoPci,
Good point about the Disabled, but the I2C pins are NC in gpio. […]
So do not set I2C bus 2/3/5 disable? right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibff1446ccb213abce1a2ae19718774d9d6737cc9
Gerrit-Change-Number: 36086
Gerrit-PatchSet: 3
Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Ben Kao ben.kao@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Marx Wang marx.wang@intel.com
Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 17 Oct 2019 03:55:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ben Kao ben.kao@intel.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment