9 Oct
2020
9 Oct
'20
2:24 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44039 )
Change subject: mb/google/volteer: Use device aliases ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... PS5, Line 22: device pci 07.0 off end # TBT_PCIe0 0x9A23 : device pci 07.1 off end # TBT_PCIe1 0x9A25
Don't we still need these as baseboard devicetree is enabling them? Also the tbt_dma0?
Not addressed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44039
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5620004afd7fa4d50389f32dd79148960a2b2662
Gerrit-Change-Number: 44039
Gerrit-PatchSet: 8
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 21:24:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment