Attention is currently required from: Elyes Haouas.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83503?usp=email )
Change subject: azalia: Get rid of "return {-1,0}
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83503/comment/983bc493_c53f6f93?usp... :
PS2, Line 9: Modern C uses {true,false}
No. Please see https://doc.coreboot.org/contributing/coding_style.html#function-return-valu...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83503?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icea33ea3e6a5e3c7bbfedc29045026cd722ac23e
Gerrit-Change-Number: 83503
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 17 Jul 2024 18:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes