Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49496 )
Change subject: coreboot_table: Use precision when printing lb_gpio name ......................................................................
coreboot_table: Use precision when printing lb_gpio name
The lb_gpio coreboot table entries use name fields fixed to 16 bytes. GCC will not allow creating a static initializer for such a field with a string of more than 16 characters... but exactly 16 characters is fine, meaning there's no room for the terminating NUL byte. The payloads (at least depthcharge) can deal with this as well because they're checking the size when looking at that table entry, but our printk("%16s") does not and will happily walk over the end until somewhere else in memory we finally find the next NUL byte.
We should probably try to avoid strings of exactly 16 characters in this field anyway, just in case -- but since GCC doesn't warn about them they can easily slip back in. So solve this bug by also adding a precision field to the printk, which will make it stop overrunning the string.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: Ifd7beef00d828f9dc2faa4747eace6ac4ca41899 --- M src/lib/coreboot_table.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/49496/1
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index e00c2a4..390a943 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -167,7 +167,7 @@ " NAME | PORT | POLARITY | VALUE\n", gpios->count); for (g = &gpios->gpios[0]; g < &gpios->gpios[gpios->count]; g++) { - printk(BIOS_INFO, "%16s | ", g->name); + printk(BIOS_INFO, "%16.16s | ", g->name); if (g->port == -1) printk(BIOS_INFO, " undefined | "); else