Attention is currently required from: David Wu, Morris Hsu, Shelley Chen, Sheng-Liang Pan.
Felix Held has posted comments on this change by Morris Hsu. ( https://review.coreboot.org/c/coreboot/+/83821?usp=email )
Change subject: mb/google/brox/jubilant: Add Fn key scancode
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/83821/comment/ae27c860_abfc18cd?usp... :
PS3, Line 4: default 94 if (BOARD_GOOGLE_LOTSO || BOARD_GOOGLE_JUBILANT)
i wonder if it would be better to have one line per variant, but that's probably something that can be looked into once more variants are added
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83821?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I963b0aa85598097fea69ec34d1e79ec0bbec3db3
Gerrit-Change-Number: 83821
Gerrit-PatchSet: 3
Gerrit-Owner: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Attention: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 09 Aug 2024 17:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No