Hello Aaron Durbin, Aamir Bohra, Duncan Laurie, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31261
to look at the new patch set (#2).
Change subject: mb/google/hatch: Replace part-specific SPD files with generic ones ......................................................................
mb/google/hatch: Replace part-specific SPD files with generic ones
Traditionally, we have always allocated 1 DRAM ID per part number. However, on nami, we have run out of DRAM IDs because we have supported so many different parts. We are now adopting the use of generic SPD files that are feature-based rather than specific to each part, allowing us to support multiple parts with a single SPD.
The common SPDs were created by taking current SPDs in Nami (which is using the same DDR4 parts as Hatch) and zeroing out all the manufacturer information and part names. Additionally, we zeroed out bytes 128 (raw card extension, module nominal height), 129 (module maximum thickness), and 130 (reference raw card used) after verifying that they are not used in FSP. We verified with these fields zeroed out, all nami devices could boot up without errors. We also verified on the two Hatch skus that we have (4G 2400, 8G 2666) that the generic SPDs boot properly.
BUG=b:122959294 BRANCH=None TEST=Make sure that we can boot up on both 4G Samsung and 8G Hynix DDR4 devices that we currently have.
Change-Id: I14d9e6b13975b6a65b506e6cd475160711b8f6d4 Signed-off-by: Shelley Chen shchen@google.com --- C src/mainboard/google/hatch/spd/16G_2400.spd.hex C src/mainboard/google/hatch/spd/16G_2666.spd.hex R src/mainboard/google/hatch/spd/4G_2400.spd.hex C src/mainboard/google/hatch/spd/8G_2400.spd.hex R src/mainboard/google/hatch/spd/8G_2666.spd.hex M src/mainboard/google/hatch/variants/baseboard/Makefile.inc 6 files changed, 37 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/31261/2