Attention is currently required from: Martin L Roth, Angel Pons, Martin Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68545 )
Change subject: console: Add a 32-bit vendor post-code call
......................................................................
Patch Set 2:
(1 comment)
File src/console/post.c:
https://review.coreboot.org/c/coreboot/+/68545/comment/e2b7944a_bb55828a
PS1, Line 22: uint32_t
If you want, I can update it to 8-bit for now, and expand it to 32-bits later as part of the overall redesign.
Yeah I think that would be better, then it will make more sense to the reviewers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0369e4362840d7506d301105d8e1e2fd865919f4
Gerrit-Change-Number: 68545
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 20 Oct 2022 23:34:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment