[coreboot-gerrit] Change in coreboot[master]: src/security/vboot: Setup secure counter space in TPM NVRAM

[Julius Werner (Code Review)]

Attention is currently required from: Andrey Pronin, Raul Rangel, Yu-Ping Wu, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59476 )

Change subject: src/security/vboot: Setup secure counter space in TPM NVRAM
......................................................................

Patch Set 1:

(1 comment)

File src/security/vboot/secdata_tpm.c:

https://review.coreboot.org/c/coreboot/+/59476/comment/56fa1597_afa867cd 
PS1, Line 368: 		rv = tlcl_read(index, &value, SECURE_COUNTER_SIZE);
> wait, we actually do something: https://review.coreboot.org/c/coreboot/+/23456/ […]

Oh okay, sorry, I should read things more closely before I talk like I knew things. But like you said, looks like that should also already work for this case without requiring extra logic.

As for the increment, I would prefer if we could just leave it out here to keep firmware code simpler (see comment on line 355). Can't we just do that on first use in userspace?