Attention is currently required from: Shelley Chen.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80085?usp=email )
Change subject: mb/google/brox: enable WIFI_SAR
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/brox/variants/brox/variant.c:
https://review.coreboot.org/c/coreboot/+/80085/comment/f753125b_c1d327aa :
PS2, Line 5: #include <baseboard/variants.h>
While you're here, could you alphabetize <baseboard/variants.h> and put it above <chip.h> please? Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80085?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I212c80412141e7770a512bd8ccf4111963bab395
Gerrit-Change-Number: 80085
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Comment-Date: Fri, 19 Jan 2024 19:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment