Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45554 )
Change subject: mb/getac/p470/acpi: Convert 'battery.asl' to ASL 2.0 syntax ......................................................................
Patch Set 2:
(3 comments)
pretty sure all of those ^^PCI0. are incorrect,
https://review.coreboot.org/c/coreboot/+/45554/2/src/mainboard/getac/p470/ac... File src/mainboard/getac/p470/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/45554/2/src/mainboard/getac/p470/ac... PS2, Line 3: Scope(_SB) { _SB is technically more correct. the \ indicates root of the hierarchy
https://review.coreboot.org/c/coreboot/+/45554/2/src/mainboard/getac/p470/ac... PS2, Line 21: If (^^PCI0.LPCB.EC0.BAT) { I don't think that's right, the current scope here is `_SB.BAT0`, so going up 2 is `\PCI0.LPCB.EC0.BAT`, which isn't correct; I think the correct relative path here is `^PCI0.LPCB.EC0.BAT`
https://review.coreboot.org/c/coreboot/+/45554/2/src/mainboard/getac/p470/ac... PS2, Line 128: If (^^PCI0.LPCB.EC0.BAT2) { same problem as above