Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134362): https://review.coreboot.org/c/coreboot/+/59666/comment/fc8b4e32_caf663ef PS4, Line 20: for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134362): https://review.coreboot.org/c/coreboot/+/59666/comment/c2b6dafe_7cb81c60 PS4, Line 32: die("Couldn't find correct port mapping or Invalid input port \n"); unnecessary whitespace before a quoted newline