[coreboot-gerrit] Change in coreboot[master]: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Mary Ruthven, Joel Kitching, Furquan Shaikh, Vadim Bendebury, Christian Walter, Julius Werner.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51164 )

Change subject: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC
......................................................................

Patch Set 1:

(1 comment)

File src/security/tpm/tss/vendor/cr50/cr50.h:

https://review.coreboot.org/c/coreboot/+/51164/comment/92f07111_3c825b4b 
PS1, Line 104:  Issue a halt() after triggering EC reset because cr50 leaves 50 ms after receiving
             :  * the command to reset the EC.
> Should the function perform a halt() too instead of expecting the caller to do it?

I don't have a strong opinion. For error scenario, this function returns to the caller with the error code. I felt it will be consistent to return to the caller even on the success scenario.