Attention is currently required from: Johnny Lin, Ed Sharma, Martin Roth.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )
Change subject: commonlib/fsp_relocate: Fix Coverity Issues
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68637/comment/906dfb56_3edf7bb8
PS1, Line 9: Recently committed change 1df1cf9 resulted in some Coverity
There is no gerrit ID. […]
Instead of "https://review.coreboot.org/c/coreboot/+/66819", you could just have [CB:66819] as the hyperlink, this is the convention. 66819 is the gerrit ID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I635c62929e8be9a474a91a62c29c3b5ee9b0ee64
Gerrit-Change-Number: 68637
Gerrit-PatchSet: 2
Gerrit-Owner: Ed Sharma
aeddiesharma@fb.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ed Sharma
aeddiesharma@fb.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 25 Oct 2022 15:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Ed Sharma
aeddiesharma@fb.com
Gerrit-MessageType: comment