Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier.
Martin Roth has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83400?usp=email )
Change subject: soc/amd/mendocino: Fix APOB NV size/base for non-vboot builds
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83400/comment/d18f4ce3_baf70fd7?usp... :
PS1, Line 10: , and
Maybe ". These' to avoid a run-on sentience.
Done
https://review.coreboot.org/c/coreboot/+/83400/comment/208ff952_b22ffe0f?usp... :
PS1, Line 12: if
and
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83400?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9be1699d675331b46ee9c42570700c2b72588025
Gerrit-Change-Number: 83400
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 09 Jul 2024 22:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com