Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c
File src/drivers/intel/ish/ish.c:
https://review.coreboot.org/#/c/31682/4/src/drivers/intel/ish/ish.c@43
PS4, Line 43: firmware-variant
Hi Jett, I was thinking on similar lines, and that is reflected in my earlier driver implementation. […]
Rushikesh, what was the alternate proposal? And did the internal mailing list understand that different projects will one utilize different fw and provide different functionality? What was their proposal for disambiguating the correct firmware to load -- as well as binding the proper kernel drive based on implementation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8be986185282521aee574027503eaf8968e1508
Gerrit-Change-Number: 31682
Gerrit-PatchSet: 5
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Mon, 04 Mar 2019 17:32:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: rushikesh s kadam
rushikesh.s.kadam@intel.com
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Gerrit-MessageType: comment