Attention is currently required from: Bao Zheng, Rob Barnes.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63722 )
Change subject: mb/google/nipperkin: Fix WLAN to GEN2 speed
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/63722/comment/78923d16_6d19b5b3
PS4, Line 10: /* Disable PSPP to avoid S0ix hangs - b/228830362 */
: memset(dxio_descriptors[WLAN].port_params, 0,
: sizeof(dxio_descriptors[WLAN].port_params));
My understanding is PSPP is on but link speed is limited to a max of gen2 speeds. […]
Hi Rob, noted, thank you!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I988365e51aca0d6515c5605b3032521cf59d8d30
Gerrit-Change-Number: 63722
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Thu, 21 Apr 2022 05:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Chiu
kevin.chiu.17802@gmail.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment