Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Make hfsts1 common & add helper functions
......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35226/25//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35226/25//COMMIT_MSG@9
PS25, Line 9: Host FW status 1 (FWSTS1/HFSTS1) register definition is common across SoCs,
APL is just dumping all the FWSTS registers and not utilising the decoded FWSTS1.
But is FWSTS1 the same for APL as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5c12b7abdb27c38af74ea6ee568b42ec74bcb3c
Gerrit-Change-Number: 35226
Gerrit-PatchSet: 25
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Sep 2019 19:39:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment