ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31651 )
Change subject: lint/clang-format: set to 96 chars per line
......................................................................
Patch Set 2:
experiences from Go:
1. "nobody likes the output of gofmt; everyone likes gofmt"
not everyone likes every single thing about gofmt, but everyone likes not having to worry about formatting.
2. The arguments over requiring gofmt were about as angry as the arguments here; they're all forgotten now
3. gofmt output has changed over time. So, should we decide in 20 years that 102 char lines are ok, we can.
I think Patrick's idea makes a lot of sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9293a69d1bea900da36501cde512004d0695ad37
Gerrit-Change-Number: 31651
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: ron minnich
Gerrit-Comment-Date: Sat, 09 Mar 2019 22:35:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment