Attention is currently required from: Felix Singer, ron minnich.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80470?usp=email )
Change subject: util: Add hda-decoder
......................................................................
Patch Set 4:
(1 comment)
File util/hda-decoder/go.mod:
https://review.coreboot.org/c/coreboot/+/80470/comment/6ecfc4d3_b12415e2 :
PS4, Line 1: module review.coreboot.org/coreboot.git/util/hda-decoder
I'm really not into Go, but is it needed to hard-code that here?
Well, we are in the same camp. 😄
AFAIK this is how you do it. This file was generated automatically by `go mod init`. The URL is the usual way of naming modules (unique and can be pulled into other programs easily by downloading from the URL).
`intelp2m` also does the same thing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80470?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4fb652e178517b2b7aceaac8be005c5b2d3b03e
Gerrit-Change-Number: 80470
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 19 Feb 2024 12:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment