Attention is currently required from: Patrick Rudolph, Tim Wawrzynczak, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56017 )
Change subject: Documentation: Improve x86_64 ......................................................................
Patch Set 7: Code-Review+1
(8 comments)
File Documentation/arch/x86/x86_64.md:
https://review.coreboot.org/c/coreboot/+/56017/comment/d00f4047_29f155e1 PS7, Line 36: compability Still not fixed: compa*ti*bility
https://review.coreboot.org/c/coreboot/+/56017/comment/9d8c4fd5_6da6c429 PS7, Line 40: phase plural `phases`?
https://review.coreboot.org/c/coreboot/+/56017/comment/50394c22_7e63d1e2 PS7, Line 41: runs If the above is changed to plural, this also needs to be changed to `run`
https://review.coreboot.org/c/coreboot/+/56017/comment/9bfd6069_a8104b9b PS7, Line 45: the compiler Which one? `the compiler` sounds like there's only one compiler, which is not the case.
https://review.coreboot.org/c/coreboot/+/56017/comment/ab2d646b_4172a772 PS7, Line 45: when nit: Capitalize `When` for consistency with the other bullet points
https://review.coreboot.org/c/coreboot/+/56017/comment/3a481d74_9dfe2d25 PS7, Line 49: todays today's
https://review.coreboot.org/c/coreboot/+/56017/comment/7fc9cacc_8854636c PS7, Line 109: Options `Option` (`Option ROMs` is a compound name, the plural `s` is in `ROMs`)
https://review.coreboot.org/c/coreboot/+/56017/comment/d4339484_60edc069 PS7, Line 125: Until now it could be verified by FOSS developers on various Intel platforms : and no issues have been found. I'd prefer to avoid using the word `verify` here, as there's no way to ensure x86_64 in CAR is fully working. Instead, how about:
However, coreboot developers working on x86_64 support have tried this on various Intel platforms, and so far haven't found any issues with CAR when running in x86_64 mode.