Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43571 )
Change subject: mb/system76/lemp9/gpio: 2/2 Convert field macros to PAD_CFG ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... PS3, Line 143: PAD_CFG_GPI_APIC
lol I was right.. just checked s76's github repo... […]
For context: System76 did some fixes for this board downstream [1], but they haven't been upstreamed yet. So, this code is out-of-date and it isn't worth fixing it as-is.
This code got upstreamed through CB:38463 which was submitted on January 27. According to history, there have been several fixes to this mainboard afterwards [2], none of which seem to have been upstreamed yet.
[1]: https://github.com/system76/coreboot [2]: https://github.com/system76/coreboot/commits/system76/src/mainboard/system76...