Attention is currently required from: Furquan Shaikh, Julius Werner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47827 )
Change subject: cbfstool: Replace FILENAME_ALIGN 16 with ATTRIBUTE_ALIGN 4 ......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:
https://review.coreboot.org/c/coreboot/+/47827/comment/4b546f14_a311d2c6 PS11, Line 118: #define CBFS_ATTRIBUTE_ALIGN 4 Should we add an _Static_assert for existing attribute structs to guarantee that? This would also make the alignment requirement easier to notice if someone were to add a new attribute in the future.
I mean, if *I* were to add a new attribute and saw there's an _Static_assert for each existing attribute, I would look at the definition of `CBFS_ATTRIBUTE_ALIGN` and notice the comment. But even if one bluntly copy-pasted an existing entry, one would probably copy-paste the _Static_assert too.