Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43771 )
Change subject: mb/volteer: Disable TBT if platform is only USB3
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43771/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/43771/1/src/mainboard/google/voltee...
PS1, Line 39: }
the devicetree entries appear to only be used to set these settings (pci 07.0-07. […]
Yes, I was referring to the USB4 controllers and the DMA controllers in the device tree. (07.0-07.3 and 0d.2-0d.3)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43771
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I594f2e9483aaf896de2b6aea9a3460bd3826c58c
Gerrit-Change-Number: 43771
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 23 Jul 2020 23:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment