Attention is currently required from: Julius Werner, Kyösti Mälkki, Lean Sheng Tan, Maximilian Brune, Nico Huber, Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76071?usp=email )
Change subject: arch/arm64: Hook up ACPI table generation ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76071/comment/80474058_8ed9dad3 : PS4, Line 9: Linux
What version did you test with?
No idea. I did not test this. @Max?
https://review.coreboot.org/c/coreboot/+/76071/comment/24fb2342_722759c2 : PS4, Line 9: Linux is able to detect and use ACPI tables on an out of tree target
`Possible repeated word: 'via'` […]
Done
https://review.coreboot.org/c/coreboot/+/76071/comment/6b279a09_e3e9b3c6 : PS4, Line 10: using hacked version of u-boot to pass the via via UEFI.
Ah, you mean instead of one of the words *via*.
Done
File src/arch/arm64/tables.c:
https://review.coreboot.org/c/coreboot/+/76071/comment/97f5c122_bde447ee : PS4, Line 18: printk(BIOS_ERR, "Increase ACPI size\n");
I see that this is the same as what x86 already does, but this is a truly terrible API. We're running straight over other CBMEM spaces and this isn't even an assert(), just a BIOS_ERR print. Can we (in a separate patch effort) fix write_acpi_tables() to actually take an upper bound and respect it?
The whole acpi generation code is very unsafe... I added an assert here but making ACPI generation more safe is a larger effort.