Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common ......................................................................
Patch Set 4:
(2 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83452/comment/7a4ba1f5_df1f33ca?usp... : PS4, Line 507: # Options controlling the kind of output I like that the warning options are reorganized and sorted, but not sure if it really makes sense to give each group a comment, since some only have one option anyway. I would remove the comments.
https://review.coreboot.org/c/coreboot/+/83452/comment/2dafc994_c34b16ae?usp... : PS4, Line 543: CFLAGS_common += -g Maybe move this before the warning options, so that the list continues with them.