Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35555 )
Change subject: mediatek/mt8183: Save DRAM calibration result to shuffle for DVFS switch
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35555/7/src/soc/mediatek/mt8183/emi...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35555/7/src/soc/mediatek/mt8183/emi...
PS7, Line 345: emi_init2(params);
BTW I swapped these 2 functions and Krane booted correctly.
the EMI setting(EMI registers) only need do once, is not relationship with the DRAM frequency.
so only need do all EMI setting once.
Attention, the bootup sequence of is very importance for DRAM, otherwise system maybe not-stable. All changes need be confirmed with the DRAM designer team, some changes maybe need do hardware simulation(those maybe take several weeks).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97c8e513dc3815a2d62b2904a246a1d8567704a4
Gerrit-Change-Number: 35555
Gerrit-PatchSet: 7
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Oct 2019 07:28:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-MessageType: comment