Attention is currently required from: Christian Walter, Michał Żygowski.
Maciej Pijanowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/73972?usp=email )
Change subject: intelmetool: Add PCI ID for TGL-U, ADL-P, ADL-S
......................................................................
Patch Set 5:
(1 comment)
File util/intelmetool/intelmetool.h:
https://review.coreboot.org/c/coreboot/+/73972/comment/d2005983_1220954c?usp... :
PS1, Line 441: #define PCI_DEVICE_ID_INTEL_TIGERLAKE 0xA0E0 /* Tiger Lake */
: #define PCI_DEVICE_ID_INTEL_ALDERLAKE_P 0x51E0 /* Alder Lake P */
: #define PCI_DEVICE_ID_INTEL_ALDERLAKE_S 0x7AE8 /* Alder Lake S */
Now when I look at it, those extra IDs are for HECI2/3/4 devices, which typically are not available. […]
Rebased and added back the original entries
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73972?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c2617a8e2f77f322f43b93ef1083576faaa42a8
Gerrit-Change-Number: 73972
Gerrit-PatchSet: 5
Gerrit-Owner: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Mon, 24 Jun 2024 18:59:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com