Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/84256?usp=email
to review the following change.
Change subject: DEMO:amdfwtool: Add PHX2 ......................................................................
DEMO:amdfwtool: Add PHX2
Change-Id: I64e33f17a5ce334aed501e4b9eb4862c63efce5a Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/84256/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 480b09b..0dd60cc 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -614,6 +614,7 @@ case PLATFORM_CEZANNE: case PLATFORM_MENDOCINO: case PLATFORM_PHOENIX: + case PLATFORM_PHOENIX2: case PLATFORM_GLINDA: case PLATFORM_CARRIZO: case PLATFORM_STONEYRIDGE: @@ -644,6 +645,7 @@ break; case PLATFORM_MENDOCINO: case PLATFORM_PHOENIX: + case PLATFORM_PHOENIX2: case PLATFORM_GLINDA: break; case PLATFORM_CARRIZO: @@ -684,6 +686,9 @@ case PLATFORM_PHOENIX: psp_id = 0xBC0D0400; break; + case PLATFORM_PHOENIX2: + psp_id = 0xBC0D0B00; + break; case PLATFORM_GENOA: psp_id = 0xBC0C0111; break; @@ -1516,6 +1521,7 @@ case PLATFORM_CEZANNE: case PLATFORM_MENDOCINO: case PLATFORM_PHOENIX: + case PLATFORM_PHOENIX2: case PLATFORM_GLINDA: case PLATFORM_GENOA: amd_romsig->spi_readmode_f17_mod_30_3f = cb_config->efs_spi_readmode; @@ -1575,6 +1581,7 @@ switch (soc_id) { case PLATFORM_MENDOCINO: case PLATFORM_PHOENIX: + case PLATFORM_PHOENIX2: case PLATFORM_GLINDA: return false; default: diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 0e8ace6..0fd8da2 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -27,6 +27,7 @@ PLATFORM_MENDOCINO, PLATFORM_LUCIENNE, PLATFORM_PHOENIX, + PLATFORM_PHOENIX2, PLATFORM_GLINDA, PLATFORM_GENOA, }; diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c index a1615ae..3503c20 100644 --- a/util/amdfwtool/data_parse.c +++ b/util/amdfwtool/data_parse.c @@ -113,6 +113,8 @@ return PLATFORM_LUCIENNE; else if (!strcasecmp(soc_name, "Phoenix")) return PLATFORM_PHOENIX; + else if (!strcasecmp(soc_name, "Phoenix2")) + return PLATFORM_PHOENIX2; else if (!strcasecmp(soc_name, "Glinda")) return PLATFORM_GLINDA; else if (!strcasecmp(soc_name, "Genoa")) @@ -736,6 +738,7 @@ case PLATFORM_CEZANNE: case PLATFORM_MENDOCINO: case PLATFORM_PHOENIX: + case PLATFORM_PHOENIX2: case PLATFORM_GLINDA: case PLATFORM_GENOA: return true;